darktable-org / darktable-org/darktable

Color labels in extended overlays visible when overlay is hidden

Open
#22,040 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

In lighttable, if one adds color label icons to extended overlays (variable LABELS.ICONS), if an image has a color label, this is displayed immediately and permanently, even when the extended overlays are displayed only on hover. This can be reversed only by disabling extended overlays.

Image
Steps to reproduce
  1. Go to settings->lighttable
  2. Add $(LABELS.ICONS) somewhere in the pattern for extended overlays (one before the last entry)
  3. Close settings
  4. Open the overlay settings (star menu, top right of the lighttable)
  5. Select extended overlays on mouse over
  6. Add some color labels to some image, if none is labeled in the current view
Expected behavior

Darktable should draw the entire extended overlay on mouse hover, including optional color labels, and clear the entire extended overlay, including optional color labels, on mouse out

Logfile | Screenshot | Screencast

https://pastebin.com/8RW6xheQ

But I don't see anything in the log that seems related. I am running a nightly of 5.7 to test the new alignment algorithm, but the problem was present in 5.6 and maybe earlier.

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.7.0+199~g085052a1d7

What OS are you using?

Mac

What is the version of your OS?

26.6.2

Describe your system

Mac mini m1

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

Integrated

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in the lighttable with $(LABELS.ICONS) in the extended-overlay pattern and extended overlays set to mouse over. Start by tracing the lighttable overlay rendering and hover state, then verify that color labels follow the same visibility state as the rest of the extended overlay. Done means the full overlay, including optional color labels, appears on hover and clears on mouse out.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.