darktable-org / darktable-org/darktable

Rotate and Perspective not shown as active after drawing a correction-line

Open
#21,995 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: regression scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

While working on a picture in darkroom and showing all active modules: when drawing a correction line by holding the right mouse button and dragging the cursor, the desired rotation is applied after releasing the mouse button. However the "rotate and perspective" module is not added to the module list on the right side. I need to click the "show only active modules" icon twice to have it finally listed in the list of active modules.

Steps to reproduce
  1. change to darkroom, click the "show only active modules" icon
  2. apply a rotation correction by right-click-dragging the mouse
  3. release the button, see that rotation is applied
  4. see that the module is not shown as an active module
  5. click the "show only active modules" icon twice and see that the module is listed now
Expected behavior

darktable should add the module to the visible active modules after applying a rotation

Logfile | Screenshot | Screencast

No response

Commit

7d0b974240

Where did you obtain darktable from?

self compiled

darktable version

5.7.0+617~g7d0b974240

What OS are you using?

Linux

What is the version of your OS?

Linux Mint 22.3 Cinnamon 64bit

Describe your system

32GB RAM
Kernel 7.0.0-30
X11

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

Intel TigerLake-LP GT2 [Iris Xe Graphics], i915 / OpenCL neo 26.31.39395.13

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

Don't know if this is important, I'm working with the touchpad of my laptop, not with a physical mouse.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in darktable's darkroom with “show only active modules” enabled, using the right-button drag correction-line gesture described in the steps. Trace how the rotate and perspective module is added to the active-module list after the gesture, and verify that it appears immediately after release without toggling the filter twice.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
56/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.