darktable-org / darktable-org/darktable

Build failure with USE_LIBRAW=OFF

Open Beginner friendly
#21,721 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Every other optional image loader (OpenEXR, WebP, JPEG XL, AVIF, HEIF, GraphicsMagick, ImageMagick) falls back to _unsupported_type when its library isn't built in, but dt_imageio_open_libraw is missing that guard.

Steps to reproduce

build with USE_LIBRAW=OFF

Expected behavior

should build

Logfile | Screenshot | Screencast

fix could be as simple as adding the following lines to imageio.c:

#ifndef HAVE_LIBRAW
#define dt_imageio_open_libraw _unsupported_type
#endif

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

5.7.0

What OS are you using?

Windows

What is the version of your OS?

11

Describe your system

msys2 on windows

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in imageio.c and inspect the existing guards for optional image loaders alongside dt_imageio_open_libraw. Build darktable with USE_LIBRAW=OFF on the reported Windows/MSYS2 setup and confirm the build succeeds without the LibRaw loader.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, computer-vision
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.