darktable-org / darktable-org/darktable

Framing module doesn't overwrite existing framing module settings

Open
#21,474 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity scope: image processing
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

In my library I have thousands of images, some with borders of one type for editing, another for instagram, others for print, and many without borders.

When I set up a style for export with the framing module set, it is additive to the current framing module rather than overwriting it. I understand why this is happening but I don't think it's useful. If I want to batch export images with a square border for instagram, or no border for printing for example, the style should be set to append and ignore any exisitng framing modules, rather than adding to them.

Alternatively being able to disable modules in the style setup would be another way of achieving this as I could then disable the existing framing module and add the new one to the base image.

I couldn't see another way to set the framing on a batch export so am open to suggestions.

Cheers

Steps to reproduce
  1. Set up style module with only framing module with desired settings
  2. use this style and export image
Expected behavior

use only appended framing, not add it to the existing framing setting on the original image

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.6

What OS are you using?

Windows

What is the version of your OS?

Windows 10 pro x64

Describe your system

No response

Are you using OpenCL GPU in darktable?

No response

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in darktable 5.6: apply a style containing only the framing module to an image that already has framing settings, then export it. Trace the framing module and style-export handling to determine how existing settings are combined. Done means the style's framing settings replace the existing framing for export, or the supported alternative is clearly implemented and tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.