darktable-org / darktable-org/darktable
Preview will shrink crop area if rotation is used
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
The crop area shrinks whenever I press W (the preview thing).
This only seems to happen when I enable the rotate and perspective module and set some rotation and then try to crop with 16:9 (only seems to happen to some aspect ratios).
Steps to reproduce
- Open an image (for example the provided one)
- Enable the
rotate and perspectivemodule - Set rotation to some value (for example -2˚)
- Enable the
cropmodule - Set crop aspect ratio to 16:9
- Repeatedly press
Wfor preview
Expected behavior
The crop selection shouldn't shrink between previews (pressing W)
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
Flatpak
darktable version
darktable 5.4.1
What OS are you using?
Linux
What is the version of your OS?
NixOS Unstable
Describe your system
No response
Are you using OpenCL GPU in darktable?
I dont know
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in darktable 5.4.1 on Linux with the rotate and perspective and crop modules enabled, using a 16:9 crop and repeated W presses. Trace the preview interaction for rotation and cropping; done means the crop selection remains unchanged between previews.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100