darktable-org / darktable-org/darktable

RFC: Search field on accels window

Open
#20,677 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

The accels window displaying all the shortcuts available on the current view (open with hotkey h) is very useful. However, at least for me, it is sometimes not easy to quickly find the right shortcut in the list because of the many entries.
Therefore, I propose a simple search function on the window like shown in the following screenshot:

Image

A new input field at the top center is introduced, where the user can enter a search string. Next to it, there is a button to start the search. As a result, all entries containing the entered search string are highlighted. In the example, the found entries are simply printed as bold. The search is a simple substring search.
The search field is only active and visible when the view is switched to sticky, as obviously only then entries can be made.

If there is a chance for this to be accepted, I would be happy to provide a PR.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the accels window implementation and the code handling its sticky view, using hotkey h as the entry point. Confirm how shortcut entries are rendered, then define the search input and button behavior. Done means the field is visible only in sticky mode and substring matches are highlighted or shown in bold.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.