darktable-org / darktable-org/darktable

Live samples in global color picker don't retain their saved position

Open
#20,461 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Loading live samples into the active color picker sometimes removes them from their original position into a different live sample's position.

I'm not sure if I'm misunderstanding how to use live samples in color picker, but this seems like a bug to me.

Steps to reproduce
  1. Open global color picker
  2. Check "display samples on image/vectorscope" to see the bug easily
  3. Save at least 2 live samples using global color picker (doesn't matter if point/area or locked/unlocked)
  4. Right-click on any live sample to load it into active color picker
  5. Right-click on any live sample again (whether the same one from the previous step, or a different one)
  6. Observe that one of the live samples moves to the position of another live sample
Expected behavior

darktable should not change the position of a live sample when loading different samples into the active color picker

Logfile | Screenshot | Screencast

darktable-log.txt

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.4.1

What OS are you using?

Windows

What is the version of your OS?

Windows 11 Pro 26200.7840

Describe your system

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA GeForce RTX 3080 Ti | Memory 12GB | Driver version 595.71

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

Can you reproduce with a RAW or JPEG or both?
Both

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through the global color picker using two live samples, with “display samples on image/vectorscope” enabled. Trace the live-sample loading path and verify that repeatedly loading samples leaves each saved sample at its original position; add or run a regression test if the relevant test location is identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.