darktable-org / darktable-org/darktable

Styles: Append not working with hierarchical instance names

Open
#20,362 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Assume for an image, a module instance named "category1|preset1" is already present and active.
There is also a style containing the same module, but with an instance name "category1|preset2" (and completely different settings). This style shall be applied to the image with the "append" mode.
As a result, the initial instance with preset1 is overwritten/replaced with preset2.
However, if the instance "category1|preset1" is renamed to "preset1" before applying the style, the result are two instances of the module.
To my understanding, the designed behavior is that instances get overwritten by the style if they have the same name.
It seems, though, that for instances with names containing a |, only the first part of the name is taken for comparison with the already present instances.

Steps to reproduce

As an example, use the D&S module. Create two styles, one with an instance of the preset "artistic effects|bloom", one with "artistic effects|simulate line drawing".
Apply the first style to an image, switch mode to "append" and apply the second style.
Check in darkroom.

Expected behavior

darktable should take the complete instance name into account.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

8b6ade32f6

What OS are you using?

Linux

What is the version of your OS?

Linux Mint 21.1 Cinnamon

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the issue in darkroom with D&S styles named “artistic effects|bloom” and “artistic effects|simulate line drawing,” then trace the append behavior for module instance matching. Done means applying both styles preserves two distinct instances with their complete hierarchical names.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.