darktable-org / darktable-org/darktable
Retouch clipped after rotate and perspective
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
In the standard pixel pipe when Rotate and perspective moves the "patch" out of the image the destination il clipped (see attachment 2).
Moving "retouch" before "Rotate and perspective" fixes the problem
Steps to reproduce
- Retouch the image copying a "patch" taken from the border of the image over a distracting detail
- Rotate and perspective moving the patch out of the image
- The patched area is now only partially covered
- move the Retouch module before "Rotate and perspective" to fix the problem
Expected behavior
Darktable should consider the original full image when retouching
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
distro packaging
darktable version
5.4.0
What OS are you using?
Linux
What is the version of your OS?
Ubuntu 24.10
Describe your system
No response
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
nvidia
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in darktable 5.4.0 using the standard pixel pipe: retouch a border patch, then apply Rotate and perspective so the patch leaves the image. Compare the result with Retouch placed before Rotate and perspective, then trace these modules' processing to determine why the destination is clipped. Done means the retouched area remains fully covered when the transform moves the patch out of the image.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100