darktable-org / darktable-org/darktable
Possible issue in negadoctor
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
The linear to cineon log formula in the Cineon white paper is incorrect
https://github.com/NatronGitHub/openfx-misc/issues/76
incorrect cineon = (log10((v + offset) /gain)/ (0.002 / gamma) + whitepoint)/1023
correct cineon = (log10(v/gain + offset )/ (0.002 / gamma) + whitepoint)/1023
Negadoctor is based on cineon conversion so it could be incorrect too.
Steps to reproduce
.
Expected behavior
No response
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
darktable.org / GitHub release
darktable version
5.4.0
What OS are you using?
Linux
What is the version of your OS?
Windows
Describe your system
No response
Are you using OpenCL GPU in darktable?
None
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the negadoctor implementation and compare its linear-to-Cineon conversion with the formula in the linked Cineon reference and openfx-misc issue #76. Trace how the conversion is used and determine whether the reported parenthesization applies. Done means the issue is confirmed or ruled out with a reproducible result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100