darktable-org / darktable-org/darktable
Rate group script: culling mode keeps jumping back to the first image
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
When I rate or reject an image in lighttable, there's a big chance lighttable will just jump back to the first image in the strip. The issue seems to be in the "rate group" script.
Steps to reproduce
- Have "rate group" Lua script enabled.
- Open lighttable and select a film strip.
- Click "selection" -> "select all".
- Select any image apart from the first one in the strip.
- Keep pressing shortcuts to give the selected image different ratings.
- At some point the strip will return to the very first image.
Expected behavior
If the image still matches the filters applied, lighttable should not change selection and displayed image; and if it doesn't, lighttable should always just pick the next image in the strip to be selected and displayed.
Where did you obtain darktable from?
distro packaging
darktable versions tested
5.2.1, 5.4.0
What OS are you using?
Linux
What is the version of your OS?
Arch
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
Similar issues are all closed: #5735, #6566, #7774.
This one may be related too: #19569 (I think the current image gets deselected for a brief moment, and then lighttable fails to find the next one, or something like that)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by enabling the rate group Lua script and reproducing the selection jump in lighttable using the listed steps and tested versions. Compare behavior when the image remains in the applied filters with behavior when it does not; done means the current image stays selected when valid, otherwise the next image is selected and displayed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100