darktable-org / darktable-org/darktable

Contrast Equalizer: Remember the Radius of Influence "circle size" in Presets (module and custom camera presets)

Open
#19,804 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

difficulty: hard no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is your feature request related to a problem? Please describe.

Yes. I use Contrast Equalizer as part of my scene-referred flow, replacing unsharp mask, for a few years now. Literally every Single time I use it (hence thousands of times now) before tweaking contrast in the module I have to change the Radius of Influence to my preferred setting (very small, as I generally prefer to have the changes apply to a narrow slice of 'coarseness').

I use presets for each of my cameras and for some combinations of camera/lens/situation, where all my preferred modules are active and set accordingly, including Contrast Equalizer which I always use. Unfortuantely, my chosen "radius of influence" is not saved in either the module's own presets nor in my custom presets for my camera/lens etc combinations.

Describe the solution you'd like

Please save the radius of influence circle size, or give an option to do so if for any reason this is not convenient to everyone (I can't see why this would not be convenient to anyone?)

Alternatives

Possible options,

  • enable this only for the Contrast Equalizer where it's critical annoying not to have it
  • enable 'saving Radius of Influence in presets' in all modules that use radius of influence by default.
  • add an advance setting that enables saving of Radius of Influence size in presets of all modules that have this control

Additional context

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Contrast Equalizer control and the preset serialization paths for module presets and custom camera presets. Verify how the radius of influence is currently handled, then confirm that the chosen circle size is saved and restored in both preset types without changing unrelated settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.