darktable-org / darktable-org/darktable
RGB Curve module - make it edit the whole curve
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
It seems this module works on a sort of [0,1] tone basis even though it is a scene-referred module. The upper part of the tonal range cannot be edited because it is off to the right of the display and so not accessible for placing control points.
It would be nice if you could edit the whole range. The histogram in the module would need to be for the whole range. Perhaps the x-axis might become too big with sparse pixels tailing off to the max in the image. Perhaps a math function could be used, log?, to keep the curve neat and manageable.
As the module stands, it seems it cannot be used for e.g. editing bright sky.
This suggestion originates from this post here - https://discuss.pixls.us/t/baffled-by-rgb-curve-module/54302/1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the RGB Curve module and reviewing the linked discussion for the reported scene-referred behavior. Determine how the module’s histogram and x-axis currently limit control points, then define a manageable whole-range representation; done means bright and upper-tonal regions can be edited and the histogram reflects the full range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100