darktable-org / darktable-org/darktable
Update visualisation of primaries sliders to look similar to that in AgX
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Prompted by https://github.com/darktable-org/darktable/pull/19642#pullrequestreview-3446581214
AgX uses an inaccurate, exaggerated, but highly visible visualisation for it 'primaries' sliders (hue and purity). Would it make sense to use the same for rgb primaries and sigmoid?
What would most probably make sense, even if the visualisation is not updated, is setting feedback = 0, so the white overlay does not obscure the slider. This method is already used for some sliders.
color balance rgb:
AgX:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the primaries slider visualisations in color balance rgb, AgX, and sigmoid, using the linked AgX discussion as context. Decide whether to match AgX’s visualisation or set feedback to 0, then verify that the white overlay no longer obscures the sliders and that the resulting display is consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- design, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100