darktable-org / darktable-org/darktable

Saving a style then applying it applies it partially to modules that had a preset on at some point?

Open
#19,524 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug
  1. apply a white balance preset
  2. change some module properties
  3. create a module from current history stack
  4. select all
  5. save
  6. open another image
  7. quick access for applying any of your styles
  8. pick that style
  9. white balance has the value of the preset (and indicates it's presetted!) instead of the value in the source image
Expected behavior

the values should be what was saved

Logfile | Screenshot | Screencast

https://github.com/user-attachments/assets/e1cdd5d6-aab9-4681-81a3-e59e34049f0b

The style made above: testR.dtstyle.gz

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.2.1

What OS are you using?

Windows

What is the version of your OS?

Windows 10

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

This is a JPEG, it reproduces with a blank history, no lua.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in darktable 5.2.1 using the attached testR.dtstyle.gz style and the described preset, history-stack, save, and quick-apply sequence. Trace how the style is saved and applied, then verify that applying it restores the saved values rather than the earlier white-balance preset state.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.