darktable-org / darktable-org/darktable

Newline handling in thumbnail pattern settings

Open
#19,497 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Darktable seems to honor newlines in the two thumbnail pattern settings ("pattern for the thumbnail extended overlay text" and "pattern for the thumnail tooltip (empty to disable)" in the "lightable" tab of the settings), but then only saves the first line so the patterns do not survive a restart.

Ideally, Darktable would preprocess the setting, save newlines as $(NL) (if need be), and restore $(NL) to the os-appropriate newline characters when loading the settings.

In any case, it should behave consistently and either limit input to one line or save/restore multi-line patterns correctly.

Affected version: Darktable 5.2.1 on linux (flatpak)

Steps to reproduce
  1. go to the "lightable" tab in the settings windows
  2. enter a mlti-line (with actual newlines, not $(NL)) in either of the last two fields
  3. verify that the pattern is applied
  4. close and restart Darktable
  5. verify that the pattern was not saved correctly
Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.2.1

What OS are you using?

Linux

What is the version of your OS?

tumbleweed (flatpak)

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in darktable's settings window using multiline values in the thumbnail extended overlay text and tooltip pattern fields. Check how those values behave before and after restarting the application; done means multiline patterns are either consistently rejected or preserved and restored correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.