darktable-org / darktable-org/darktable

Lighttable selection not updated at shift-click if the cursor isn't moved

Open
#19,406 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

I want to delete a range of pictures from the lighttable view, by clicking the first, then shift-clicking the last, then pressing Del on the keyboard in Darktable 5.2.1 on X11.

If the mouse is not moved after shift-clicking, Darktable only offers to delete 1 photo (the one under the cursor). If the mouse is moved even by a few pixels, staying within the last selected picture, Darktable correctly asks me if I want to delete the selection I made.

I guess this is easier to reproduce on a laptop with a trackpoint / touchpad with physical buttons, as a mouse typically moves a bit when trying to click.

Steps to reproduce
  1. Have lighttable open with multiple pictures
  2. Click one picture
  3. Shift-click another picture
  4. Press Del on the keyboard
Expected behavior

darktable should offer to delete all selected pictures

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

distro packaging

darktable version

5.2.1-1

What OS are you using?

Linux

What is the version of your OS?

Debian sid

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin by reproducing the issue in darktable's lighttable view on Linux using the listed click, shift-click, and Delete steps. Trace the lighttable selection update path, comparing shift-click with and without subsequent pointer movement; the payload names no source file or test. Done means the deletion confirmation covers the entire selected range without moving the cursor.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.