darktable-org / darktable-org/darktable
Centering crop when selecting a preset
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Is your feature request related to a problem? Please describe.
When enabling a crop preset which is narrower than the original image (e.g. 1:1 crop on a 3:2 image), the crop is automatically applied at the right edge.
Describe the solution you'd like
The crop should be applied at the center of the image. This is what the cameras also do, when enabling e.g. a 1:1 crop in the camera.
Alternatives
Of course it's possible to just move the crop manually to the center, but it's one additional step.
It is also possible to create a general preset which crops in the middle.
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is identified in the issue. Start by locating the code that applies a crop preset and reproduce a narrower preset on a wider image; done means the preset initially positions the crop at the image center while still allowing manual repositioning, with regression coverage if existing tests cover this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100