darktable-org / darktable-org/darktable
Masks are lost when used in styles
Open
@ralfbrown is already working on this.
Since Dec 16, 2024.
feature: enhancement
no-issue-activity
scope: image processing
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Describe the bug
When a module in a style has a mask, this mask is not correctly re-applied with the style.
Steps to reproduce
- Start with a freshly reset image.
- Add a circle mask to the exposure module.
- Increase the exposure. This only affects the masked area.
- Create a style using the "3 circles" icon just right of the button "compress history stack". Include the exposure module.
- Reset the image history.
- Apply the style.
Result:
The exposure module shows a mask-symbol, but the mask is fully opaque, so the exposure change is applied to the whole image.
Expected behavior
Darktable should apply the change only in the masked area.
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
self compiled
darktable version
4.8.1, 8ded880839-dirty
What OS are you using?
Linux
What is the version of your OS?
Debian Bookworm
Describe your system?
I tested this on
- 4.8.1 from scoop on Windows 10
- 4.8.1 from Flathub on Debian Bookworm
- Current git 8ded880839-dirty on Debian Bookworm
Are you using OpenCL GPU in darktable?
No
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.