darktable-org / darktable-org/darktable
Adhere to the system colouration.
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Rationale
(At least ⪆ 3.0.0rc0 of) Darktable looks utterly different to every application on my OS. Occasionally, I have my OS set to a high contrast theme which Darktable can't match, and even when I don't, the inconsistency makes utilising its GUI unintuitive.
The Desired Solution
In effect, add color-scheme: light dark to your text/CSS, with prefers-color-scheme: implicitly set to the current value of org.freedesktop.appearance.color-scheme (whether no-preference, prefer-dark, or prefer-light).
Considered Alternatives
In descendent order of desirability:
-
Utilise a GUI toolkit which automatically does so (like Qt). However, I presume that this is infeasible.
-
Manually apply the colouration provided by the OS/DE:
-
On Windows, utilise
learn.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.uisettings.getcolorvalue?view=winrt-26100. ^1 -
On GNOME or KDE, use the values in the
gtkrc(or better yet, on KDE, adhere to the current.colorfile's INI-formatted values).
-
Additional Context
-
I'm not whatsoever suggesting CSD like
issues/13555#issue-1573410812does. Adherence to the DE's appearance in any manner except colouration is outside the purview of this issue. I also happen to not be fond of non-SSDs. -
The current status-quo has, occasionally, caused invisible elements. ^2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating darktable's GUI text/CSS and the entry points that select application colours. Compare the requested light, dark, and high-contrast behaviour with the referenced Windows, GNOME, KDE, and freedesktop appearance sources. Done means the interface follows the system colour scheme without addressing unrelated desktop-environment or CSD changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, css
- Domain
- accessibility, design, desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100