darktable-org / darktable-org/darktable
Grouping of images can add non-selected photos
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Describe the bug
In group mode, when adding images to a group, non-selected photos can be added to a group.
Steps to reproduce
- Enter group mode
- Select images
a.jpganda.raw- top level message says that 2 images are selected - Press Ctrl-G to group images - group is created as expected
- Select images
b.jpg,b.raw, andb-1.jpg- top level message says that 3 images are selected; note thatb-1.jpgis a distinct file on disk. - Press Ctrl-G to group images - group of 5 images is created and consists of
a.*andb*photos - There is one group of images, instead of two
This might happen randomly. Seems more prevalent with hundreds of images in a roll.
Expected behavior
There should be two group of images, not one.
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
distro packaging
darktable version
4.8.1
What OS are you using?
Linux
What is the version of your OS?
ArchLinux
Describe your system?
No response
Are you using OpenCL GPU in darktable?
I dont know
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the grouping sequence in darktable 4.8.1: group a.jpg with a.raw, then b.jpg, b.raw, and b-1.jpg, especially with a large roll. Trace the group-mode selection and Ctrl-G entry point to find why earlier photos remain included. Done means the same steps create two groups containing only the currently selected images.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100