darktable-org / darktable-org/darktable

Grouping of images can add non-selected photos

Open
#17,306 11 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Describe the bug

In group mode, when adding images to a group, non-selected photos can be added to a group.

Steps to reproduce
  1. Enter group mode
  2. Select images a.jpg and a.raw - top level message says that 2 images are selected
  3. Press Ctrl-G to group images - group is created as expected
  4. Select images b.jpg, b.raw, and b-1.jpg - top level message says that 3 images are selected; note that b-1.jpg is a distinct file on disk.
  5. Press Ctrl-G to group images - group of 5 images is created and consists of a.* and b* photos
  6. There is one group of images, instead of two

This might happen randomly. Seems more prevalent with hundreds of images in a roll.

Expected behavior

There should be two group of images, not one.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

distro packaging

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

ArchLinux

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the grouping sequence in darktable 4.8.1: group a.jpg with a.raw, then b.jpg, b.raw, and b-1.jpg, especially with a large roll. Trace the group-mode selection and Ctrl-G entry point to find why earlier photos remain included. Done means the same steps create two groups containing only the currently selected images.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.