darktable-org / darktable-org/darktable
Photoswipe outdated, should be upgraded and made an optional feature
@wpferguson is already working on this.
Since Nov 27, 2024.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Describe the bug
The embedded Photoswipe copy is an outdated version from 2015:
/*! PhotoSwipe - v4.1.1 - 2015-12-24
However, the nature of the project changed a lot and Photoswipe is not a "simple jQuery based JS library" anymore but requires npm to build as of version 5.
An upgrade to the recent version is strongly recommended.
Furthermore, Photoswipe support should be made an optional feature which is not turned on by default, in both cases (sticking to the old version and upgrading to the new version). When sticking with the old version, users can be warned that they enable support for an outdated JS library. When upgrading to the new version, only users who want to use Photoswipe will require npm at build time. Another reason is that Linux distributions don't like embedded libraries for multiple reasons.
Steps to reproduce
Go to data/pswp in the source code, check version of Photoswipe.
Expected behavior
darktable should not ship with outdated JS libraries.
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
downloaded from www.darktable.org
darktable version
4.6
What OS are you using?
Linux
What is the version of your OS?
Debian Sid
Describe your system?
No response
Are you using OpenCL GPU in darktable?
None
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.