darktable-org / darktable-org/darktable
Preset names lost when applying style
Open
@TurboGit is already working on this.
Since Dec 5, 2023.
difficulty: hard
feature: redesign
priority: low
scope: DAM
wip
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Describe the bug
I have a preset that contains 2 instances of diffuse or sharpen, both built-in ones:
- sharpen demosaicing: AA filter
- local contrast
Previously, when I applied the style, the two instances were shown accordingly. Now, they are shown as:
The style contains:
<plugin>
<num>17</num>
<module>2</module>
<operation>diffuse</operation>
<op_params>
0100000000000000080000000000803f000000000000803f0000803f0000803f0000803f00000000000080be000080be000080be000080be00000000
</op_params>
<enabled>1</enabled>
<blendop_params>gz09eJxjYGBgYAFiCQYYOOHEgAZY0QVwggZ7CB6pfOygYtaVAyCMi48L/AcCEA0AmawnoA==</blendop_params>
<blendop_version>12</blendop_version>
<multi_priority>1</multi_priority>
<multi_name>sharpen demosaicing: AA filter</multi_name>
<multi_name_hand_edited>0</multi_name_hand_edited>
</plugin>
<plugin>
<num>16</num>
<module>2</module>
<operation>diffuse</operation>
<op_params>
0a00000000000000800100000000803f0000803f000020c00000000000000000000020c000000000000000bf0000000000000000000000bf00020000
</op_params>
<enabled>1</enabled>
<blendop_params>gz09eJxjYGBgYAFiCQYYOOHEgAZY0QVwggZ7CB6pfOygYtaVAyCMi48L/AcCEA0AmawnoA==</blendop_params>
<blendop_version>12</blendop_version>
<multi_priority>0</multi_priority>
<multi_name>local contrast</multi_name>
<multi_name_hand_edited>0</multi_name_hand_edited>
</plugin>
Steps to reproduce
Apply the attached style to a photo.
Expected behavior
Display the module instance names
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
self compiled
darktable version
4.5.0+1391~g0a39901aa5-dirty (because of the tone-eq experiment from https://github.com/darktable-org/darktable/issues/15743#issuecomment-1828292364)
What OS are you using?
Linux
What is the version of your OS?
Ubuntu 23.10
Describe your system?
No response
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
not relevant
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.