darktable-org / darktable-org/darktable

deprecate graduated nd filter - only produces artifacts/halos

Open
#13,840 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: pending priority: medium release notes: pending scope: image processing
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Hi,

I would like to suggest to add the graduated filter module to the deprecated modules. It only produces artifacts and halos. People can use exposure with a mask and colorize instead.

I think I know how to do this in the code, although I have not tried yet.

I can add examples later if people don't know what I mean.

Unfortunately I don't know how to fix this in the module and I suspect it's not so easy to fix since this "bug" has been present for many years now.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the graduated filter module and the code that registers modules as deprecated; compare it with the exposure, mask, and colorize modules mentioned in the issue. Mark graduated nd as deprecated and verify that the module is represented consistently wherever deprecated modules are listed.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics, desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.