darktable-org / darktable-org/darktable

rework the final-scale and make it possible to have a sharpen after downscaling

Open
#13,682 20 comments 3 reactions 2 assignees View on GitHub

@jenshannoschwalm is already working on this.

Since Feb 19, 2023.

feature: enhancement priority: high release notes: pending scope: color management scope: image processing
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

For the final-scale there is discussion to happen here.

For the final sharpen there is also discussion to happen here.

I had this proposal:

  • Introduce a new hidden module named finalsharpen
  • Make this module disabled by default
  • This new module has a single parameter strength to allow for setting the amount of sharpening (0 = None)
  • A new slider "final sharpening" is introduced into the export module (0 by default) up to (100%)
  • When this slider is > 0 during export the finalsharpen module is enabled
  • The actual strength is passed to it using config key

This issue is to track down the discussion for the implementation of those two issues. Please keep this discussion focused.

EDIT: Initial discussion was in #13635.

EDIT: From reference, having the finalscale doing the job in linear data is a good goal for quality.

EDIT: Moving downscale before any tone curve (Sigmoid, Filmic...) means that all modules after that will work in down-scaled images, what is the impact on quality?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.