darktable-org / darktable-org/darktable

[FR] Fixed position proposal for the styles preview in the lighttable.

Open
#12,872 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature: enhancement priority: medium scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is your feature request related to a problem? Please describe.

Looking at the recent addition of the styles preview in the styles module of the lighttable, great BTW, I saw that the preview pop-up changes size depending on the number of modules applied to the image development that have been added as a style. The pop-up size changes back and forth indifferently showing these modules and the name of the style is repeated in the list and in the preview.

Describe the solution you'd like

It would be good to achieve greater consistency in the preview of the styles, to have fixed the position of this preview, where what changes is the image horizontally or vertically and use the icon already recognized by users to show the number of modules applied as part of the style, this icon is present both in the lighttable view and in the previews of the culling layout. Only if users place the mouse pointer over the icon, the pop-up menu will be displayed.

In that case it won't be necessary to repeat the style name as it is now in the pop-up and the preview will be resizable using the Ctrl+scroll shortcut as the graphs in curves or filmic.

Of course, it would be necessary to find another solution to the preview of the styles in the darkroom, since the same thing happens there, the pop-up menu shows the styles, and the window changes sizes with their corresponding modules applied and saved as styles.

reference images

Screenshot from 2022-11-11 19-04-30
Screenshot from 2022-11-11 19-04-53
Screenshot from 2022-11-11 19-05-19

icon used in the culling layout with the popup menu.

Screenshot from 2022-11-11 17-54-25

mockup proposal

version with fixed 1x1 box with the image inside in horizontal or vertical position and the icon to show the used modules in the current selected style.

Style_window_v01

version with image taking the biggest area possible in horizontal or vertical position and the icon to show the used modules in the current selected style.

Style_window_v02

@TurboGit @Nilvus PS. Sorry for my useless English. :-)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the styles preview in the lighttable and darkroom, comparing the current popup behavior with the reference images and mockups. Review the existing style-preview UI entry points and any related tests, which are not named in the issue. Done means a consistent fixed preview position, image resizing behavior, module-count icon interaction, and an agreed darkroom solution.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
design, desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.