darktable-org / darktable-org/darktable
Do not use wildcard to search children tags on collections module (and maybe other things, consistency needs to be improved too)
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.1k
- Forks
- 1.4k
- Avg merge
- 22h 14m
- Merged PRs (30d)
- 198
Description
Describe the bug/issue
I can't search a children tag on collections module. @phweyland: as you work on that, maybe you will have some ideas to fix that.
To Reproduce
- Be sure to have no other filter that will go against your search (having all images displayed)
- Select tag filter on collections module
- Type a tag which is a children, not first parent
- See that collections list became empty.
Expected behavior
When typing any tag, independently of hierarchy, the tag should be displayed to allow display related images.
Hard to know when this issue was introduced. I didn't use that search since months but I remember that this was working, at least last year.
Platform
- darktable version : actual master
- Linux - Distro : Debian Sid
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the collections module on actual master by filtering for a child tag with all images displayed. Trace the tag-filter search path and inspect how hierarchical tags are queried. Done means any tag in the hierarchy displays related images, without the wildcard behavior causing an empty collection; check whether the same consistency issue affects other searches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop, search
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100