darktable-org / darktable-org/darktable

Improve star rating filter

Open
#11,757 89 comments 1 reaction 0 assignees View on GitHub

A pull request for this has already been merged.

  • #11801 by @AlicVB — merged
feature: enhancement scope: UI understood: clear
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

A couple of issues with the new star rating filter in the top bar of the lighttable view.

The first is that, in its default (all selected) state, it draws the eye a bit too much and can be distracting - it's quite bright and high-contrast.

The second is that it is somewhat hard to read at-a-glance. If I select a range of ratings, especially in the middle of the range, I have to look hard to see which stars I've selected. For example:

Screenshot_2022-05-07_22-49-21

The main thing I see when I just glance at this control is that two stars are highlighted. But I have to engage extra brain functions to work out which two stars are selected (is it two to three, or four to five?). In the previous interface, I usually used "greater than or equal to" by default so when I saw two stars highlighted in the top bar I instantly knew what that meant without having to think further (two == two or more stars). It's "intuitive" in the way that looking at an analogue clock is. In the new way it's the opposite, in that if I select "two or more stars", I will actually see three stars highlighted. This is hard on my tiny brain.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the star rating filter in the top bar of the lighttable view and review the screenshot and linked pull request for existing context. Define a less distracting default appearance and a selection display that makes the chosen rating range immediately clear; done means both concerns are resolved in the lighttable UI.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
design, desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.