darkreader / darkreader/darkreader

[BUG] Dark Reader breaks Gotty Terminal Emulation during macOS dark mode

Open
#5,932 9 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
TypeScript
Stars
22.4k
Forks
2.7k
Avg merge
21h 11m
Merged PRs (30d)
78

Description

# Bug Report

## Describe the bug

On macOS when the OS theme is dark, then Dark Reader causes https://github.com/yudai/gotty (this is a terminal emulation in a browser window) to display the whole content of the emulated CLI in one row only.
## Steps to reproduce

- turn macos dark mode on
- Install gotty (in a unix terminal). See https://github.com/yudai/gotty
- create a browser terminal with `gotty htop`
- open browser (I tested Google Chrome and Brave) with Dark Reader installed
- open the link provided by gotty (e.g. localhost:8080)

## Expected behavior

Full terminal in browser
## Actual behavior

Broken one liner terminal in browser
## Screenshots

macOS day Theme - no problem:
![Screenshot 2021-06-03 at 07 58 15](https://user-images.githubusercontent.com/24418160/120594786-bac01180-c441-11eb-8ec4-8e58829bf76a.png)
macOS darkmode + Darkreader extension is enabled (but not necessarily in dark mode):
![Screenshot 2021-06-03 at 07 58 47](https://user-images.githubusercontent.com/24418160/120594792-bc89d500-c441-11eb-9d8f-b57b6bd070fd.png)
macOS darkmode but Darkreader extension is disabled (for comparison) - no problem again:
![Screenshot 2021-06-03 at 08 01 28](https://user-images.githubusercontent.com/24418160/120594965-fbb82600-c441-11eb-9095-e7a35e025892.png)
## System Information

- OS: macOS 11.3 (Big Sur)
- Browser: Brave 1.24.86, Chrome 90
- Dark Reader Version: 4.9.33

## Additional context

Pausing Dark Reader does not help, only disabling the extension fixes the terminal!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.