darkoperator / darkoperator/Posh-SSH
New-SSHShellStream $TerminalName should default to `dumb` not `PoshSSHTerm`
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 1.1k
- Forks
- 222
- PR merge metrics
- No merged PRs in 30d
Description
All trace logs on my Posh-SSH commands reveal:
tput: unknown terminal "PoshSSHTerm"
This is because the default terminal type defined in Posh-SSH.ps1 for New-SSHShellStream() is defined as "PoshSSHTerm". And becomes the default terminal "Type" passed into whatever linux host we are connecting to. However tehre is no default definition for "PoshSSHTerm" in most linux distros, so tput returns the error above in the Powershell trace commands (start-transcript).
The easy solution is to select -TermnialName 'dumb' when calling the cmdlet New-SSHShellStream, dumb is defined in most Linux Distros (no error message from tput), and won't display any escape characters that confuse powershell.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Posh-SSH.ps1 and inspect the New-SSHShellStream() definition, especially the default terminal name passed to the Linux host. Change the default to dumb and verify that invoking the cmdlet without an explicit terminal name no longer produces the reported tput warning or confusing escape characters in PowerShell traces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- cli, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100