dapr / dapr/quickstarts

Investigate commented out tutorial validations

Open
#1,187 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.1k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Many of the tutorial validations in the [GitHub validate_tutorials.yaml](https://github.com/dapr/quickstarts/blob/master/.github/workflows/validate_tutorials.yaml) file are commented out and thus not running.

```yaml
# - name: Validate distributed-calculator
# if: matrix.os == 'ubuntu-latest'
# run: |
# pushd tutorials/distributed-calculator
# make validate
# popd
# - name: Validate pub-sub
# if: matrix.os == 'ubuntu-latest'
# run: |
# pushd tutorials/pub-sub
# make validate
# popd
# - name: Validate bindings
# if: matrix.os == 'ubuntu-latest'
# run: |
# pushd tutorials/bindings
# make validate
# popd
# - name: Validate secretstore
# if: matrix.os == 'ubuntu-latest'
# run: |
# pushd tutorials/secretstore
# make validate
# popd
# - name: Validate observability
# if: matrix.os == 'ubuntu-latest'
# run: |
# pushd tutorials/observability
# make validate
# popd
```

I've tried to run the bindings and secretstore validations locally and they are failing.

I presume these validations have been commented out (temporarily) to get a green validation result.

I suggest we investigate why these validations are failing, and fix where possible.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.