dapr / dapr/java-sdk

Remove dependencies and tests that are not needed for CA / SSL

Open
#1,364 0 comments 0 reactions 0 assignees View on GitHub
kind/bug
Dominant language
Java
Stars
300
Forks
230
Avg merge
1d 20h
Merged PRs (30d)
4

Description

## Expected Behavior

The SDK shouldn't include test dependencies to test the behavior of other libraries or functionality that is out of the scope from the SDK.

## Actual Behavior

This PR:

[](https://github.com/dapr/java-sdk/commit/daf4c8b7030f963110f29b3c08ade14babd83c33)

Added the following dependencies that are not needed and we shouldn't have in the SDK:

```

org.bouncycastle
bcprov-jdk15on
1.70
test


org.bouncycastle
bcpkix-jdk15on
1.70
test

```
It also added complex tests in the following Test class:

[sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java](https://github.com/dapr/java-sdk/commit/daf4c8b7030f963110f29b3c08ade14babd83c33#diff-b7c65e0352b8116b33b92da139dac5fd3527fb1672f592c180a1b560651f0c78)

These tests are not necessary here because the SDK is not responsible for checking that the certificates are correctly generated. We should only test and assert that the certificates are set if the correct properties are set.

Also, all the previously existing tests are now adding the channel to an ArrayList, I would love to know the reason for doing that, this should be removed if it is not serving any purpose.

## Steps to Reproduce the Problem

## Release Note

RELEASE NOTE:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.