dapr / dapr/go-sdk

GRPCWait should be deprecated

Open
#677 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
479
Forks
187
PR merge metrics
No merged PRs in 30d

Description

After [return block to client](https://github.com/dapr/go-sdk/commit/5eecffa4fa3df1825d5149471edd83e4aa89e7ba) we no longer should call `Wait` as the `WithBlock` dial option does exactly that. I believe this method is confusing as it serves no purpose and should be deprecated first and then removed.

Contributor guide

Open the contributing guide

Research direction

Locate the GRPCWait method and its current call sites, then review commit 5eecffa4fa3df1825d5149471edd83e4aa89e7ba and the WithBlock dial option. Confirm that callers no longer need Wait; done means the method is deprecated as requested, with removal handled according to the project's compatibility policy.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.