dapr / dapr/dotnet-sdk

Proposal: Change loglevel to Warning for duplicate priorities in pubsub topic subscriptions

Open
#992 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
1.2k
Forks
378
Avg merge
1d 22h
Merged PRs (30d)
5

Description

I have multiple `TopicAttribute`s on the same topic with different filters. The priority of the filters doesn't matter, because they don't overlap. Without a priority on the attribute, the SDK will log the error below. In my opinion this should be warning instead of an error, because:

- The application continues execution and is functioning properly
- Monitoring tools will pick up the false-positive error

https://github.com/dapr/dotnet-sdk/blob/e6ded69ca440e6767e96e0c128cbb920f1ee4070/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs#L126

Let me know what you think, I can submit a PR if you want.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.