dapr / dapr/dotnet-sdk

Move `using`s outside the namespace defintion

Open
#489 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.2k
Forks
378
Avg merge
1d 22h
Merged PRs (30d)
5

Description

## Describe the proposal

The dotnet-sdk codebase uses the convention of placing `using`s inside the namespace declaration. This is an old convention that was enforced by some linting tools back in the day, and it isn't the way most modern C# code looks - especially OSS code.

The best reasons to change this:
- The other major C# OSS code bases use `using`s outside (consistency with popular projects)
- The defaults for tools like VS, Rider, `dotnet new` place `using` directives outside the namespace - our code style fights with the defaults most users will have

There **is** actually a small semantic difference between placing usings inside vs outside. If anyone can tell me what it is without looking it up, you win a free copy of Dapr 😛

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.