dapr / dapr/components-contrib
Add support for pagination with Query API in Redis State Store
- Dominant language
- Go
- Stars
- 602
- Forks
- 580
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 6
Description
It seems that the paginated Query API is not being unit tested for Redis as - for example - is done here for Postgresql:
https://github.com/dapr/components-contrib/blob/c693061efb732c538d4c3a09e9936f8bc49c8726/common/component/postgresql/v1/postgresql_query_test.go#L36-L43
## Expected Behavior
Add a unit test that checks that pagination works with Query API on Redis State Store
## Actual Behavior
Query API on Redis State store seems not to be working correctly (at least on 1.12.4) when using "limit" and "token" parameters.
## Steps to Reproduce the Problem
Try Query API with pagination parameters (token and limit) on a Redis State Store anche check that the correct responses are received.
## Release Note
RELEASE NOTE: **FIX** Pagination management on Query API for Redis.
Contributor guide
Research direction
Start by comparing the Redis State Store Query API implementation and tests with common/component/postgresql/v1/postgresql_query_test.go, especially the pagination cases using limit and token. Reproduce the reported Query API request against Redis, then verify that paginated responses and continuation tokens are correct in a unit test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, redis
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100