dapr / dapr/cli

Mutli-app-run should monitor processes and close on exit

Open
#1,354 3 comments 0 reactions 0 assignees View on GitHub
area/cli area/test/e2e kind/feature kind/proposal P1 triaged/resolved
Dominant language
Go
Stars
353
Forks
221
Avg merge
3d 8h
Merged PRs (30d)
2

Description

## Describe the proposal
Today if you do the multi app run, e.g. on Workflow quickstart, it has some unexpected behaviors where the dapr console apps all complete and exit, but dapr run keeps running. It looks like dapr run never will exit which is unexpected, and you have to force exit with CTL C etc.

The mainline proposal is we should add process monitoring and by default exit dapr run when *all dapr app processes have exited.

There is also a case where some but not all dapr processes exit. My suggestion and leaning is we do not exit dapr in this case, because there might be valid reasons for a job to exit, but keep the services alive. We could however add a user config with a short circuit where if any processes exit, the whole dapr run exits.

## Release Note

Multi-app-run now monitors processes and exits when dapr applications exit/stop.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.