dapr / dapr/cli

[Proposal] `dapr stop` should wait until process actually exits

Open
#1,160 8 comments 1 reaction 1 assignee Claimed by @nikitasarawgi View on GitHub
area/cli good first issue kind/enhancement P1 size/S triaged/resolved
Dominant language
Go
Stars
353
Forks
221
Avg merge
3d 8h
Merged PRs (30d)
2

Description

## Describe the proposal
Currently the `dapr stop` command executes a `kill` command (or equivalent, for Windows) to stop a `dapr` or `daprd` process. However, this is asynchronous; the process may still take some time to actually exit. Scripts or other tooling that use the `dapr stop` command may have an expectation that, upon completion of `dapr stop`, processes have actually exited.

`dapr stop` should ensure that the process has exited before the command itself exits (within a suitable or perhaps configurable timeout).

## Release Note

RELEASE NOTE:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.