dapr / dapr/cli

Dapr stop should support stopping independent daprd processes in Windows

Open
#1,034 1 comment 0 reactions 0 assignees View on GitHub
P1 pinned
Dominant language
Go
Stars
353
Forks
221
Avg merge
3d 8h
Merged PRs (30d)
2

Description

## Describe the proposal
Today Windows uses named events to kill the CLI process in Windows when `dapr stop` is used.
https://github.com/dapr/cli/blob/6d3026b0cc237b6fc74353ed883846594dca22ab/cmd/shutdown_windows.go#L33-L41

Unlike Linux/Darwin, independent Daprd processes cannot be killed on Windows.

Potential solution
- Use an alternative like Taskkill with graceful shutdown (earlier removed in #638)
- Listen for specific named events in Daprd process and send a kill signal from CLI.

## Release Note

RELEASE NOTE: **ADD** support for stopping independent daprd processes using `dapr stop`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.