dapphub / dapphub/ds-token

Intentional use of accounting terms?

Open
#23 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
222
Forks
76
PR merge metrics
No merged PRs in 30d

Description

I'm wondering if the use of the words 'debit' and 'credit' in the definitions of 'mint' and 'burn' are intentionally used in the technical accounting sense of the term or not. The current wording implies that accounts are credit-normal (like a liability) and the total supply is debit-normal (like an asset). If that's the case, I think that that should be made explicit in the readme and the verbiage on https://github.com/dapphub/ds-token/blob/13e09345fb459103875a6266705a14ab6f72b6d3/README.md#L18-L24 should change to read more like

```Markdown
#### `mint`
increase (credit) tokens at an address whilst simultaneously increasing (debiting) `totalSupply`
(requires auth)

#### `burn`
decrease (debit) tokens at an address whilst simultaneously decreasing (crediting) `totalSupply`
(requires auth)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.