dapphub / dapphub/ds-guard

Guard by Default

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
24
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Would it not be cleaner and use 1 less mapping if we were to set a default state variable, for example, defaultGuard = True
Then you only need to maintain a single list of excaptions to the default,
so if the default is Guard unless allowed, then the mapping would contain a white list, if the status is Allow, then it would be a black list.
Of course, having more states than a single logic would work, I just feel having 2 address arrays is additional storage that is not space efficient, and what would happen if a Single address managed to get into both lists? My years of development have taught me to only have single source of truth.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by reviewing the DSGuard and DSAuthority behavior described by the repository, then determine whether a default guard state with one exception list preserves the authorization semantics. Done means reaching and documenting a clear design decision about replacing the two address mappings and handling addresses present in both.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
authorization, blockchain, security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.