dapphub / dapphub/ds-dach

actual relayer (msg.sender) not asserted, behaving currently as a fee_recipient

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
51
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Right now `Dach`'s Dai or Chai actions does not
```
require(relayer == msg.sender, "invalid relayer");
```

I could understand useful scenario such as a backend relaying meta-tx concurrently from differents EOAs while collecting fee on a specific address. However such implicit behaviour looks kind of "dangerous", given that **its implicit**. So right now, `relayer` parameter behave as a `fee_recipient` and if not asserted then a backend's relayer's EOA could be potentially emptied.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.