dapphub / dapphub/dapptools

dapp looks inside ./lib/ even for "innocent" commands

Open
#734 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
2.1k
Forks
320
PR merge metrics
No merged PRs in 30d

Description

This is quite weird behaviour:
```
~ » mkdir /tmp/dappthing && cd /tmp/dappthing
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/dappthing » dapp --version
dapp 0.32.2
solc, the solidity compiler commandline interface
Version: 0.6.7+commit.b8d736ae.Linux.g++
hevm 0.46.0
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/dappthing » mkdir -p lib/foo
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/dappthing » dapp --version
dapp-remappings: error: ./lib/foo is not a Git repository
dapp-remappings: error: try "dapp update" to initialize submodules
dapp 0.32.2
solc, the solidity compiler commandline interface
Version: 0.6.7+commit.b8d736ae.Linux.g++
hevm 0.46.0
```

Namely, there are some commands, for example `dapp --version`, `dapp --nix-run` etc. that shouldn't expect us to be inside a dapp-structured project. I was told this might be relevant for PR #719

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.