daphne-project / daphne-project/daphne
Merge type inference traits `ValueTypeFromFirstArg` and `ValueTypeFromThirdArg` into parametric trait
- Dominant language
- C++
- Stars
- 81
- Forks
- 83
- PR merge metrics
- No merged PRs in 30d
Description
These two traits are used for type inference and mean that the value type of the single result of an operation should be the same as that of the first/third argument, respectively. Currently, there is some obvious code duplication between these two. MLIR supports parametric traits. We should merge the two traits into a single trait like `ValueTypeFromArg` or `ValueTypeFromIthArg`.
Search for #487 in the codebase for some pointers.
Contributor guide
Research direction
Search the codebase for #487 and locate the ValueTypeFromFirstArg and ValueTypeFromThirdArg traits and their uses. Read the surrounding type-inference and MLIR trait code first, then confirm that both traits are represented by one parametric trait while preserving the existing inference behavior and updating all references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100