daostack / daostack/subgraph

add DAOToken and Reptuation contract versions to contractInfos

Open
#293 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
44
Forks
30
PR merge metrics
No merged PRs in 30d

Description

the client lib is using the contractInfos collectino to find the ABIs of the contracts, given a contract address.

This works fine, I am happy :-)

But there are two types of contract that we need the ABI for, and which ABI is in migratino.json, but that are not in the contractInfos collection.

These are:

- The reputation contracts of the DAO
- The token contracts of the DAO

The client now has the versions of these contracts hardcoded (https://github.com/daostack/client/blob/use-new-redeemer-contract/src/token.ts#L129) which is fine, as long as these contracts do not change. But it would be cleaner to include these in the subgraph index.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.