daostack / daostack/infra

Allow `queuedVoteRequiredPercentage` < 50

Open
#75 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
25
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Kei from Gnosis was interested in deploying a DAO with a queuedVoteRequiredPercentage = 20, the voting machine configuration is pasted below. It seems strange that the smart contracts would prohibit this, and it should be something that's at the user's discretion to set properly as long as it's >= 1.

Requested code change:
`require(_params[0] <= 100 && _params[0] >= 1, "1 <= queuedVoteRequiredPercentage <= 100");`

Original Code:
https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L259

Config:
```json
{
"queuedVoteRequiredPercentage": 20,
"queuedVotePeriodLimit": 604800,
"thresholdConst": 1001,
"proposingRepReward": 10,
"minimumDaoBounty": 0,
"boostedVotePeriodLimit": 172800,
"daoBountyConst": 3,
"activationTime": 0,
"preBoostedVotePeriodLimit": 43200,
"quietEndingPeriod": 43200,
"voteOnBehalf": "0x0000000000000000000000000000000000000000",
"votersReputationLossRatio": 1
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.