daostack / daostack/arc

redeem suggestion for beneficiary argument is not always effective

Open
#706 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
50
Forks
21
PR merge metrics
No merged PRs in 30d

Description

The redeem fucntion for `CompetitionSuggestion` takes a beneficiary argument that is ignored if the redeem function is called by someone that is not the original suggestor.

this means that the original suggestor cannot have any garantee that the reward arrives at the beneficiary of his choice - someone else could call redeem first...

Contributor guide

Open the contributing guide

Research direction

Start by locating the CompetitionSuggestion redeem function and trace how its beneficiary argument is handled when a caller other than the original suggestor invokes it. Reproduce the call-order scenario described in the issue, then verify that the original suggestor's chosen beneficiary is preserved regardless of who calls redeem.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.