daostack / daostack/arc

a few miscellaneous items on ExternalLocking4Reputation and Auction4Reputation

Open
#542 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
50
Forks
21
PR merge metrics
No merged PRs in 30d

Description

1. This in `ExternalLocking4Reputation.initialize` is redundant with what already exists in `Locking4Reputation._initialize`:

```
require(_lockingEndTime > _lockingStartTime,"_lockingEndTime should be greater than _lockingStartTime");
```

2. consider indexing the following event arguments:

- `FixedReputationAllocation.BeneficiaryAddressAdded._beneficiary`
- `Auction4Reputation.Bid._bidder`

3. `FixedReputationAllocation.enabled` will crash when `numberOfBeneficiaries` is zero:

```
beneficiaryReward = uint256(int216(reputationReward).div(int256(numberOfBeneficiaries)).fromReal());
```

Should we do a `require` with a message?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.