daostack / daostack/arc.js_legacy

TxTracking should not modify the client's options object

Open
#271 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
28
Forks
13
PR merge metrics
No merged PRs in 30d

Description

The TxTracking system should not modify the client's `options` object that is supplied to every Arc.js function that generates a transaction. Currently it inserts a property called `txEventContext`.

This change may require adding an optional argument to every Arc.js function that generates a transaction.

The only known alternative is to document that Arc.js adds this property, and perhaps rename the property to be more clear about where it came from.

Contributor guide

Open the contributing guide

Research direction

Start by locating the TxTracking implementation and the Arc.js functions that generate transactions. Trace where txEventContext is inserted into the client's options object and review how those functions receive options. Done means the issue's chosen approach is consistently applied without unintended mutation, with coverage or documentation matching the decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.