daostack / daostack/arc.js

where clause should allow for "blockNumber" property

Open
#554 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
13
PR merge metrics
No merged PRs in 30d

Description

The graph supports s `block` argument https://thegraph.com/docs/graphql-api#queries that we can use to get the state of the blockchain at a specific block.

this can be supported easily by adding a few lines for `options.block` in https://github.com/daostack/arc.js/blob/d80b0c36c3ced43d72b4f120af5b7c7494637d57/src/utils.ts#L109

We need this for common, where we are using the 2.0.0-experimental build

While we are doing this, it would also be a good idea to have a more restrictive type on createGraphQLQuery() that limits the kind of argument you can pass - we did not catch this at first in our code because we could add the block argument without any type error or runtime error (it just skips the argument silently)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.